[webkit-reviews] review granted: [Bug 56131] [chromium] Compositor thread infrastructure : [Attachment 88675] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Nat Duca <nduca at chromium.org>'s
request for review:
Bug 56131: [chromium] Compositor thread infrastructure
https://bugs.webkit.org/show_bug.cgi?id=56131

Attachment 88675: Patch
https://bugs.webkit.org/attachment.cgi?id=88675&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88675&action=review

Looks good to me. Just a few very minor nits to clean up.

> Source/WebCore/ChangeLog:11
> +	   functionality in CCMainThread.

This second sentence would be better at a comment at the CCMainThread.cpp
level.

> Source/WebCore/ChangeLog:36
> +	   (WebCore::CCThread::getInstance):

This isn't in this patch. (I think you need to regenerate the ChangeLog.

> Source/WebCore/platform/graphics/chromium/cc/CCThread.h:37
> +// thread is alive as long as someone holds on to a reference to the

This comment is out of date.