[webkit-reviews] review granted: [Bug 58066] REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri : [Attachment 88671] proposed fix

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 58066: REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
https://bugs.webkit.org/show_bug.cgi?id=58066

Attachment 88671: proposed fix
https://bugs.webkit.org/attachment.cgi?id=88671&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88671&action=review

> Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:193
> +	   if (!decoder->decode(start))

If something fails to decode, it will mark the argument decoder as invalid, so
you can't use that as a check for whether there are enough attributes.

A better solution is to encode the number of attributes.

> Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:196
> +	       return false;

You should return false if start > end.