[webkit-reviews] review granted: [Bug 57862] WebKit2: Implement TextChecker on Windows : [Attachment 88640] Patch (Part 3) Take 2 - attempt to fix Qt build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 10:36:07 PDT 2011

Adam Roben (:aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 57862: WebKit2: Implement TextChecker on Windows

Attachment 88640: Patch (Part 3) Take 2 - attempt to fix Qt build

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88640&action=review

Seems like there are really two things going on here:

1) Add USE(UNIFIED_TEXT_CHECKING) guards where appropriate
2) Plumb checkSpellingOfString through to the UI process

Separating those into two separate patches would be slightly clearer. But I'll
review as-is.

> Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:303
> +void TextChecker::checkSpellingOfString(int64_t, const UChar*, uint32_t,
int32_t&, int32_t&)
> +{
> +    notImplemented();
> +}

Will this ever be called on Mac (given that WebKit2 doesn't run on Leopard or
Tiger)? If not, I'd replace use ASSERT_NOT_REACHED() instead of

> Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:401
> -void WebEditorClient::checkSpellingOfString(const UChar*, int, int*, int*)
> +void WebEditorClient::checkSpellingOfString(const UChar* text, int length,
int* misspellingLocation, int* misspellingLength)

How is it possible to change this without making a similar change in the .h

More information about the webkit-reviews mailing list