[webkit-reviews] review granted: [Bug 57849] [Chromium] Add WebKit API to query and request unified offline-storage quota : [Attachment 88582] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 57849: [Chromium] Add WebKit API to query and request unified
offline-storage quota
https://bugs.webkit.org/show_bug.cgi?id=57849

Attachment 88582: Patch
https://bugs.webkit.org/attachment.cgi?id=88582&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88582&action=review

R=me because my nit picks are very minor.  Feel free to correct those and then
commit.

> Source/WebKit/chromium/public/WebStorageQuotaError.h:38
> +    WebStorageQuotaErrorOk = 0,

do you need the "ok" value?  i can't imagine didFail being called with this
value.

> Source/WebKit/chromium/public/WebStorageQuotaError.h:40
> +    WebStorageQuotaErrorSecurity = 18,

it is not very obvious what ErrorSecurity and ErrorAbort mean.	i think
ErrorAbort
will be used whenever the operation could not complete because we are shutting
down.
what does ErrorSecurity mean?

maybe the name could be improved or maybe a comment could be added or both.