[webkit-reviews] review granted: [Bug 57968] [GTK] Need a way to get the path for a WebKitWebPlugin : [Attachment 88624] patch addressing mrobinson's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 07:46:51 PDT 2011

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 57968: [GTK] Need a way to get the path for a WebKitWebPlugin

Attachment 88624: patch addressing mrobinson's comments

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88624&action=review


> Source/WebKit/gtk/webkit/webkitwebplugin.cpp:182
> + * Returns: the absolute path to @plugin in glib filename encoding.

s/glib/system. Should say it returns null on error.

> Source/WebKit/gtk/webkit/webkitwebplugin.cpp:206
> +    g_warning("Failed to convert '%s' to glib filename encoding: %s",
priv->corePlugin->path().utf8().data(), error->message);


More information about the webkit-reviews mailing list