[webkit-reviews] review granted: [Bug 53275] Fix ContentType parameter parsing error : [Attachment 88616] Modified patch based on Eric's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 06:25:36 PDT 2011


Eric Carlson <eric.carlson at apple.com> has granted Nancy Piedra
<nancy.piedra at nokia.com>'s request for review:
Bug 53275: Fix ContentType parameter parsing error
https://bugs.webkit.org/show_bug.cgi?id=53275

Attachment 88616: Modified patch based on Eric's comments
https://bugs.webkit.org/attachment.cgi?id=88616&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88616&action=review

r+ with the minor changes suggested. 

Thanks!

> Source/WebCore/ChangeLog:7
> +
> +	   Parse quotes from content type parameters
> +	   https://bugs.webkit.org/show_bug.cgi?id=53275
> +

It would be helpful to have a comment about how this change is tested, eg.
something like the comment you are adding to the LayoutTests ChangeLog.

> Source/WebCore/platform/ContentType.cpp:52
> +		   if (quote != notFound && end != notFound) // find dobule
quote

Typo: dobule -> double. However, the comment doesn't really add anything for
someone reading the code later so I would just remove it.


More information about the webkit-reviews mailing list