[webkit-reviews] review denied: [Bug 58007] [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser : [Attachment 88558] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Keith Kyzivat
<keith.kyzivat at nokia.com>'s request for review:
Bug 58007: [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=58007

Attachment 88558: Patch
https://bugs.webkit.org/attachment.cgi?id=88558&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88558&action=review

> Tools/QtTestBrowser/launcherwindow.cpp:791
> -	   setWindowState(Qt::WindowNoState);
> +	   if (m_windowOptions.preferMaximized)
> +	       setWindowState(Qt::WindowMaximized);
> +	   else
> +	       setWindowState(Qt::WindowNoState);

I think the window should come back in its previous state when going out of
fullscreen.

> Tools/QtTestBrowser/launcherwindow.cpp:883
> +    if (m_windowOptions.preferMaximized)
> +	   dialog->setWindowState(Qt::WindowMaximized);
> +    else
> +	   dialog->resize(size().width() * 0.7, dialog->size().height());

This is a dialog, that should not get maximized by default. The window manager
should decide how to handle dialogs.

> Tools/QtTestBrowser/main.cpp:186
> +		<< "[-maximized"

Missing ]


Same comments for both apps.