[webkit-reviews] review granted: [Bug 58014] Implement CSP's options directive : [Attachment 88578] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 02:53:30 PDT 2011

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 58014: Implement CSP's options directive

Attachment 88578: Patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88578&action=review

> Source/WebCore/page/ContentSecurityPolicy.cpp:454
> +	   skipWhile<isOptionValueCharacter>(position, end);
> +
> +	   String optionsValue(optionsValueBegin, position -

I would almost put a comment here noting that position may be == end, but that
we don't care.

> Source/WebCore/page/ContentSecurityPolicy.cpp:484
> +    return !m_scriptSrc || (m_options && m_options->disableXSSProtection());

Perhaps this m_options || m_options->disableXSSProtection check should be
rolled into a single dispableXSSProtection() method then you don't need to
repeat yourself.

More information about the webkit-reviews mailing list