[webkit-reviews] review denied: [Bug 57812] Re-entrancy issue with setIsAcceleratedCompositingActive : [Attachment 88181] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Antoine Labour
<piman at chromium.org>'s request for review:
Bug 57812: Re-entrancy issue with setIsAcceleratedCompositingActive
https://bugs.webkit.org/show_bug.cgi?id=57812

Attachment 88181: Patch
https://bugs.webkit.org/attachment.cgi?id=88181&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88181&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:2425
> +	       m_temporaryOnscreenGraphicsContext3D = 0;

This needs to occur in both code paths, whether or not the
LayerRendererChromium succeeded in being created, to avoid a resource leak. I
suggest using m_temporaryOnscreenGraphicsContext3D.clear() to do so.

As long as you're convinced that there are no other problems in allowing the
reentrancy, this otherwise looks fine. Please upload a revised patch (and set
cq?) and I'll r+ it. Note that the 'webkit-patch upload' script assists with
this.