[webkit-reviews] review requested: [Bug 57858] WebKit for Mac should always propagate a mouse release event to a subframe : [Attachment 88545] Patch and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 17:24:53 PDT 2011


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 57858: WebKit for Mac should always propagate a mouse release event to a
subframe
https://bugs.webkit.org/show_bug.cgi?id=57858

Attachment 88545: Patch and layout test
https://bugs.webkit.org/attachment.cgi?id=88545&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I am not exactly clear on the purpose of m_mouseDownWasInSubframe. Alexey
mentioned that this instance variable was added in r3003
<http://trac.webkit.org/changeset/3003>. From my understanding of this
changeset and the current incarnation of this source code and its call sites,
it seems that the use of m_mouseDownWasInSubframe is related to some
idiosyncrasies with NSView.

There were no layout test regressions with this patch.


More information about the webkit-reviews mailing list