[webkit-reviews] review granted: [Bug 57984] WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels : [Attachment 88514] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 17:16:52 PDT 2011

Darin Adler <darin at apple.com> has granted Chang Shu <cshu at webkit.org>'s request
for review:
Bug 57984: WebKitTestRunner needs

Attachment 88514: fix patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88514&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:183
> +	   return "";

I suggest String() instead of "".

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:186
> +    return PrintContext::pageSizeAndMarginsInPixels(coreFrame, pageIndex,
width, height,
> +						       marginTop, marginRight,
marginBottom, marginLeft);

We don’t line up lines like this in WebKit. I suggest either doing a 4 pixel
indent rather than lining things up or just putting all the arguments into one

More information about the webkit-reviews mailing list