[webkit-reviews] review granted: [Bug 40254] [Qt] FrameLoaderClientQt.cpp has coding-style errors : [Attachment 88467] Fixing previous patch submitted by Anders Bakken to fix the coding-style on FrameLoaderClientQt.cpp

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 40254: [Qt] FrameLoaderClientQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40254

Attachment 88467: Fixing previous patch submitted by Anders Bakken to fix the
coding-style on FrameLoaderClientQt.cpp
https://bugs.webkit.org/attachment.cgi?id=88467&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88467&action=review

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:97
> +static QString drtDescriptionSuitableForTestResult(WebCore::Frame*
webCoreFrame)

We normally just say coreFrame in Qt parts where we want to differentiate

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:252
> +    // notImplemented();

I dont get why that is outcommented... either remove the comment or remove the
line