[webkit-reviews] review granted: [Bug 57981] Update the CSS3 column width and count algorithm to match the spec. : [Attachment 88508] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 57981: Update the CSS3 column width and count algorithm to match the spec.
https://bugs.webkit.org/show_bug.cgi?id=57981

Attachment 88508: Patch
https://bugs.webkit.org/attachment.cgi?id=88508&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88508&action=review

> Source/WebCore/rendering/RenderBlock.cpp:4215
> +	   desiredColumnCount = max(1, (int)((float)(availWidth + colGap) /
(colWidth + colGap)));

To avoid the (int) cast you could use max<int>().

> Source/WebCore/rendering/RenderBlock.cpp:4218
> +	   desiredColumnCount = min(colCount, (int)((float)(availWidth +
colGap) / (colWidth + colGap)));

Ditto