[webkit-reviews] review requested: [Bug 32723] [Qt] QWebFrame::setUrl works only from second time if url fragment is present : [Attachment 88509] patch v5, keep a member with URL

[bugzilla-daemon at webkit.org]

Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org> has asked	for
review:
Bug 32723: [Qt] QWebFrame::setUrl works only from second time if url fragment
is present
https://bugs.webkit.org/show_bug.cgi?id=32723

Attachment 88509: patch v5, keep a member with URL
https://bugs.webkit.org/attachment.cgi?id=88509&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<caio.oliveira at openbossa.org>
Use a member to track the URL. Both setUrl() and FrameLoaderClient callbacks
will update it, the latter at the same moment that urlChanged() signal is
emitted.

Benjamin, rationale for KURL is in the ChangeLog.

Kenneth, previous approach worked even in the case you mentioned (at least as
much as I could track in the auto tests created). So no cleanup of
urlFromSetter wasn't necessary ;-). However, as we discussed before, the
current approach is simpler ("URL is in one well-known place"), and will be
less confusing to debug in the future.