[webkit-reviews] review granted: [Bug 57862] WebKit2: Implement TextChecker on Windows : [Attachment 88468] Patch (Part 2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 12:08:11 PDT 2011


Anders Carlsson <andersca at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 57862: WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Attachment 88468: Patch (Part 2)
https://bugs.webkit.org/attachment.cgi?id=88468&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88468&action=review

> Source/WebKit2/UIProcess/win/WebTextCheckerClient.cpp:73
> +    if (!m_client.uniqueSpellDocumentTag)

Do we really need to check for null here?

> Source/WebKit2/UIProcess/win/WebTextCheckerClient.cpp:81
> +    if (!m_client.closeSpellDocumentWithTag)

Ditto.


More information about the webkit-reviews mailing list