[webkit-reviews] review denied: [Bug 57804] Various layout tests depend on mp4 files. : [Attachment 88169] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 6 12:02:55 PDT 2011
Eric Carlson <eric.carlson at apple.com> has denied Steve Lacey
<sjl at chromium.org>'s request for review:
Bug 57804: Various layout tests depend on mp4 files.
https://bugs.webkit.org/show_bug.cgi?id=57804
Attachment 88169: Patch
https://bugs.webkit.org/attachment.cgi?id=88169&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88169&action=review
Great change, but I would prefer to have it split into three bugs so r- for
now.
> LayoutTests/ChangeLog:16
> + Fix the following which became exposed after unblocking the core
format
> + problem:
> +
> + - update video-load-and-stall.cgi to take a time to stall for.
Previously the
> + cgi script would just exit on stall, which can (should?) be
interpreted as a
> + network error rather than a stall (which requires 3 seconds before
firing).
> +
> + - video-play-before-metadata.html was waiting for a suspend event
which isn't
> + expected (in the *-expected.txt file). The suspend event is 'likely'
to come
> + after the onload, but might come before, making this test flakey.
I think it is worth fixing each of these in separate bugs because you are doing
more than changing the test file used.
More information about the webkit-reviews
mailing list