[webkit-reviews] review granted: [Bug 57958] Context menu does not show in PDF views if there is no UI delegate : [Attachment 88464] Proposed Change
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 6 10:39:40 PDT 2011
Darin Adler <darin at apple.com> has granted Timothy Hatcher <timothy at apple.com>'s
request for review:
Bug 57958: Context menu does not show in PDF views if there is no UI delegate
https://bugs.webkit.org/show_bug.cgi?id=57958
Attachment 88464: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=88464&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88464&action=review
> Source/WebKit/mac/WebView/WebView.mm:1277
> + // CallUIDelegate returns nil if UIDelegate is nil or dosen't respond to
the selector. So we need to check that here
Typo: dosen't
> Source/WebKit/mac/WebView/WebView.mm:1281
> + menuItems = CallUIDelegate(self, selector, element,
defaultMenuItems);
Annoying to be doing respondsToSelector twice here.
More information about the webkit-reviews
mailing list