[webkit-reviews] review granted: [Bug 53605] [GTK] The GTK+ DRT needs an implementation of the PlainTextController : [Attachment 81098] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 10:25:06 PDT 2011


Eric Seidel <eric at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 53605: [GTK] The GTK+ DRT needs an implementation of the
PlainTextController
https://bugs.webkit.org/show_bug.cgi?id=53605

Attachment 81098: Patch
https://bugs.webkit.org/attachment.cgi?id=81098&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81098&action=review

Seems sane.  It's not clear why this code can't be better shared between ports.


> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:765
> +static void addControllerToWindow(JSContextRef context, JSObjectRef
windowObject, const char* controllerName, JSValueRef controller)

Yay!


More information about the webkit-reviews mailing list