[webkit-reviews] review granted: [Bug 57916] Cull out most of the line boxes from the line box tree : [Attachment 88456] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 57916: Cull out most of the line boxes from the line box tree
https://bugs.webkit.org/show_bug.cgi?id=57916

Attachment 88456: Patch
https://bugs.webkit.org/attachment.cgi?id=88456&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=88456&action=review

One comment below (repeated).

> Source/WebCore/rendering/RenderInline.cpp:853
> +	   } else if (curr->isRenderInline()) {
> +	       // If the child doesn't need line boxes either, then we can
recur.
> +	       RenderInline* currInline = toRenderInline(curr);
> +	       InlineBox* result = currInline->firstLineBoxIncludingCulling();
> +	       if (result)
> +		   return result;

The comment is mysterious because the logic is now encompasses in
firstLineBoxIncludingCulling(). This whole block can be replaced with
} else if (curr->isRenderInline())
    return toRenderInline(cure)->firstLineBoxIncludingCulling();

> Source/WebCore/rendering/RenderInline.cpp:880
> +	   } else if (curr->isRenderInline()) {
> +	       // If the child doesn't need line boxes either, then we can
recur.
> +	       RenderInline* currInline = toRenderInline(curr);
> +	       InlineBox* result = currInline->lastLineBoxIncludingCulling();
> +	       if (result)
> +		   return result;

Ditto.