[webkit-reviews] review denied: [Bug 37514] [CSS3 Backgrounds and Borders] Implement CSS3 background-position offsets : [Attachment 79942] patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 6 10:19:10 PDT 2011
Eric Seidel <eric at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s request
for review:
Bug 37514: [CSS3 Backgrounds and Borders] Implement CSS3 background-position
offsets
https://bugs.webkit.org/show_bug.cgi?id=37514
Attachment 79942: patch2
https://bugs.webkit.org/attachment.cgi?id=79942&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79942&action=review
> Source/WebCore/css/CSSParser.cpp:2567
> +static bool isBackgroundPositionCKeyword(RefPtr<CSSPrimitiveValue> value)
You mean to use a raw pointer here. Please read
http://www.webkit.org/coding/RefPtr.html
More information about the webkit-reviews
mailing list