[webkit-reviews] review granted: [Bug 54969] [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation : [Attachment 88434] Patch v6 WebCore

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Robert Sesek
<rsesek at chromium.org>'s request for review:
Bug 54969: [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput
implementation
https://bugs.webkit.org/show_bug.cgi?id=54969

Attachment 88434: Patch v6 WebCore
https://bugs.webkit.org/attachment.cgi?id=88434&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88434&action=review

Great!

> Source/WebKit/mac/WebView/WebFrame.mm:676
> +    size_t location, length;

I don't know why I didn't mention that before, but we don't declare two
variables on one line.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:281
> +    size_t locationSize, lengthSize;

Ditto.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:296
> +    size_t locationSize, lengthSize;

Ditto.