[webkit-reviews] review requested: [Bug 52148] [Gtk] Implement support for Embedded Objects : [Attachment 88447] Patch proposal + Unit test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 52148: [Gtk] Implement support for Embedded Objects
https://bugs.webkit.org/show_bug.cgi?id=52148

Attachment 88447: Patch proposal + Unit test
https://bugs.webkit.org/attachment.cgi?id=88447&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a new patch with some changes over it, based on Chris's previous
comments.

(In reply to comment #9)
> [...]
> > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1156
> > > +#endif
> > 
> > Seems like we should have a method like textIteratorBehavior() that will
> > consolidate this logic
> 
> Ok.

Done.

> > > Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2408
> > > +
> > 
> > Instead of referencing AccessibilityRenderObject in platform code, which i 

> > don't like, I think we should either have a method renderer() on 
> > AccessibilityObject or isRendererReplaced() on accessibility object.
> 
> Ok, but as AccessibilityRenderObject is also being referenced in several
> other parts of the GTK's wrapper, I wonder whether this change shouldn't
> go in a separate patch to this one, and now focus in fixing this bug.

Done, by reporting a new bug (bug 57955) for fixing that, providing a patch
there (currently pending on review) and developing the new patch for this bug
on top of that one.