[webkit-reviews] review denied: [Bug 57948] JSC bindings generator: support non-object numbers as callback arguments : [Attachment 88424] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 57948: JSC bindings generator: support non-object numbers as callback
arguments
https://bugs.webkit.org/show_bug.cgi?id=57948

Attachment 88424: Patch
https://bugs.webkit.org/attachment.cgi?id=88424&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88424&action=review

> Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp:141
> +bool JSTestCallback::callbackWithInteger(int* intParam)
> +{
> +    if (!canInvokeCallback())
> +	   return true;
> +
> +    RefPtr<JSTestCallback> protect(this);
> +
> +    JSLock lock(SilenceAssertionsOnly);
> +
> +    MarkedArgumentBuffer args;
> +    args.append(jsNumber(static_cast<int>(intParam)));

This is definitely wrong and won’t even compile. You can’t just cast an int* to
an int.