[webkit-reviews] review denied: [Bug 57770] Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore : [Attachment 88436] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 57770: Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=57770

Attachment 88436: Patch
https://bugs.webkit.org/attachment.cgi?id=88436&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88436&action=review

> Source/WebCore/bindings/js/CallbackFunction.h:52
> +	   return JSCallbackType::create(asObject(value), globalObject);

Sorry, the refactoring I asked you for broke the function. This line will
assert or crash when asObject is called on a null or undefined value.