[webkit-reviews] review granted: [Bug 57955] [GTK] Do not reference AccessibilityRenderObject from platform dependent code : [Attachment 88443] Patch proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 57955: [GTK] Do not reference AccessibilityRenderObject from platform
dependent code
https://bugs.webkit.org/show_bug.cgi?id=57955

Attachment 88443: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=88443&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88443&action=review

looks good modulus changes

> Source/WebCore/accessibility/AccessibilityObject.h:359
> +

I would put this directly below node(), with no extra line between them,
because they are related

> Source/WebCore/accessibility/AccessibilityObject.h:410
>      virtual AccessibilityObject* correspondingControlForLabelElement() const
{ return 0; }

does correspondingLabelForControlElement need to be made virtual in
AXRenderObject.h?