[webkit-reviews] review denied: [Bug 56752] [Qt] The minimum size of the select menu list is incorrect for qtwebkit : [Attachment 87900] Updated patch with the updated new test case

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Doreen Jiang
<doreen.jiang at nokia.com>'s request for review:
Bug 56752: [Qt] The minimum size of the select menu list is incorrect for
qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752

Attachment 87900: Updated patch with the updated new test case
https://bugs.webkit.org/attachment.cgi?id=87900&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87900&action=review

r- because of the test being Qt specific without justification for that.
If a layout issue is not covered by existing test, you should improve the tests
for everyone, not just for Qt.

> Source/WebCore/ChangeLog:5
> +	   [QT]The minimum size of the select menu list is incorrect for
qtwebkit 

Qt, not QT.

> LayoutTests/ChangeLog:5
> +	   [QT]The minimum size of the select menu list is incorrect for
qtwebkit 

Qt

> LayoutTests/platform/qt/fast/forms/selectlist-minsize.html:5
> +	       [QT]The minimum size of the select menu list is incorrect for
qtwebkit <br>

Qt

> LayoutTests/platform/qt/fast/forms/selectlist-minsize.html:9
> +	   <select id="list3">

Why is there an id?