[webkit-reviews] review denied: [Bug 56131] [chromium] Compositor thread infrastructure : [Attachment 88172] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 5 20:44:51 PDT 2011
David Levin <levin at chromium.org> has denied Nat Duca <nduca at chromium.org>'s
request for review:
Bug 56131: [chromium] Compositor thread infrastructure
https://bugs.webkit.org/show_bug.cgi?id=56131
Attachment 88172: Patch
https://bugs.webkit.org/attachment.cgi?id=88172&action=review
------- Additional Comments from David Levin <levin at chromium.org>
This appears to be re-inventing stuff that is already done in WebKit (see all
of the post task infrastructure).
Also CCNonThreadSafeMember is unused and hopefully won't have a need to be used
-- better to split your object into two pieces that have items that can be
accessed from multiple threads and shouldn't be.
Also what does cc stand for? I see that it is a directory name but that doesn't
help. WebKit typically avoids abbreviations so this is unusual.
More information about the webkit-reviews
mailing list