[webkit-reviews] review granted: [Bug 57893] [Mac] WebKit2: Escape key does not stop page loads when focus is on the web page : [Attachment 88337] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 57893: [Mac] WebKit2: Escape key does not stop page loads when focus is on
the web page
https://bugs.webkit.org/show_bug.cgi?id=57893

Attachment 88337: Patch
https://bugs.webkit.org/attachment.cgi?id=88337&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88337&action=review

> Source/WebKit2/UIProcess/PageClient.h:104
> +    virtual bool executeKeypressCommand(const String& selector) = 0;

Keypress may confuse someone into thinking that the command is executed when
keypress is dispatched. But it's for keydown, as far as I can tell.