[webkit-reviews] review granted: [Bug 57869] REGRESSION (r82734): Links in Leaks Viewer's Recent Builds list don't work : [Attachment 88290] Strip off /results.html from results URLs before trying to load leaks files from them

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 57869: REGRESSION (r82734): Links in Leaks Viewer's Recent Builds list
don't work
https://bugs.webkit.org/show_bug.cgi?id=57869

Attachment 88290: Strip off /results.html from results URLs before trying to
load leaks files from them
https://bugs.webkit.org/attachment.cgi?id=88290&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88290&action=review

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentB
uildsLoader.js:65
> +			   var url = step.urls["view results"];
> +			   buildInfo.url = self._buildbotBaseURL +
url.replace(/\/results\.html$/, "") + "/";

If all the build bots point to ".../results.html" you only need to chop off the
results.html part and not add the slash. But I think the current approach works
well because it always ensures a slash at the end.