[webkit-reviews] review granted: [Bug 56233] Add --baseline-search-path to NRWT : [Attachment 88289] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 11:53:24 PDT 2011


Tony Chang <tony at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 56233: Add --baseline-search-path to NRWT
https://bugs.webkit.org/show_bug.cgi?id=56233

Attachment 88289: Patch
https://bugs.webkit.org/attachment.cgi?id=88289&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88289&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:304
> +		    "Specify multiple times to add multiple search path
entries."),

Clever

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:582
> +	   (res, buildbot_output, regular_output, user) = logging_run(
> +		['--baseline-search-path', 'foo'])

Nit: no () needed on the left hand side of the assignment


More information about the webkit-reviews mailing list