[webkit-reviews] review denied: [Bug 53066] Web Inspector: fix data url's status and timing the network panel. : [Attachment 88246] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 53066: Web Inspector: fix data url's status and timing the network panel.
https://bugs.webkit.org/show_bug.cgi?id=53066

Attachment 88246: Patch
https://bugs.webkit.org/attachment.cgi?id=88246&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88246&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1524
> +		   this._statusCell.textContent = WebInspector.UIString("(data
url)");

You need to update English.lproj/localizedStrings.js with new string.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1525
> +		   this._statusCell.addStyleClass("network-dim-cell");

Seems like this line is common.

> Source/WebCore/inspector/front-end/Resource.js:716
> +    isFromDataURL: function()

nit: isDataURL