[webkit-reviews] review denied: [Bug 56000] Move the alignment related macros in Vector.h to the new Alignment.h. : [Attachment 88196] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 5 09:50:29 PDT 2011
Darin Adler <darin at apple.com> has denied Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 56000: Move the alignment related macros in Vector.h to the new
Alignment.h.
https://bugs.webkit.org/show_bug.cgi?id=56000
Attachment 88196: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=88196&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88196&action=review
Looks fine. The Windows build failed, so please make a new patch. I’ll say
review- because we don’t want a review+ on a refactoring patch that failed on
EWS.
> Source/JavaScriptCore/wtf/Alignment.h:3
> + * Copyright (C) 2011 University of Szeged.
Since we just moved the code and made no changes, we should add a new
copyright.
More information about the webkit-reviews
mailing list