[webkit-reviews] review granted: [Bug 57822] Build fix for YarrParser.h : [Attachment 88191] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 09:43:00 PDT 2011


Darin Adler <darin at apple.com> has granted Balazs Kelemen <kbalazs at webkit.org>'s
request for review:
Bug 57822: Build fix for YarrParser.h
https://bugs.webkit.org/show_bug.cgi?id=57822

Attachment 88191: Patch
https://bugs.webkit.org/attachment.cgi?id=88191&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
If we do make this change, it will be just to make the compiler happy. When
m_state is Empty it is illegal to look at the character value, so initializing
it is only helpful to mitigate programming mistakes. If m_state is set to
another state where m_character is used, then m_character will be set
appropriately.

The compiler can’t analyze the data flow well enough to see the relationship so
it thinks there is a potential problem here, but there is none.


More information about the webkit-reviews mailing list