[webkit-reviews] review granted: [Bug 57800] [Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification. : [Attachment 88243] Patch (v2)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jia Pu <jpu at apple.com>'s request for
review:
Bug 57800: [Mac] When autocorrection occurs without showing correction panel,
WebCore need to post accessibility notification.
https://bugs.webkit.org/show_bug.cgi?id=57800

Attachment 88243: Patch (v2)
https://bugs.webkit.org/attachment.cgi?id=88243&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88243&action=review

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:77
> +#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) &&
!defined(BUILDING_ON_SNOW_LEOPARD)
> +	   case AXAutocorrectionOccured:
> +	       macNotification = @"AXAutocorrectionOccurred";
> +	       break;
> +#endif

If the enum value exists, we probably need a case for it on all versions, not
just versions newer than Snow Leopard. We could do ASSERT_NOT_REACHED on those
other versions, but we will still want the case because you did not put an #if
around the enum value.