[webkit-reviews] review granted: [Bug 57807] new-run-webkit-tests: stop driver on windows properly : [Attachment 88168] add unit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 09:16:54 PDT 2011

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 57807: new-run-webkit-tests: stop driver on windows properly

Attachment 88168: add unit test

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88168&action=review

Did you test this on win32 python and cygwin python?

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:337
> +	   self.KILL_TIMEOUT = 3.0

Nit: pull this out of __init__?  You can still refer to it with
self.KILL_TIMEOUT and shadow it in a test by setting driver.KILL_TIMEOUT.

More information about the webkit-reviews mailing list