[webkit-reviews] review granted: [Bug 57826] [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT : [Attachment 88233] Patch proposal + Updated layout tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 5 08:28:00 PDT 2011
chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 57826: [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
https://bugs.webkit.org/show_bug.cgi?id=57826
Attachment 88233: Patch proposal + Updated layout tests
https://bugs.webkit.org/attachment.cgi?id=88233&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88233&action=review
r=me with minor wording changes
> LayoutTests/ChangeLog:10
> + Also, done changes inside the aria-tables.html layout test, in
This sentence is worded awkwardly. What do you mean by "Also, done changes"
> LayoutTests/ChangeLog:16
> + just print role names instead of comparing their actual values
..."just prints..."
> LayoutTests/ChangeLog:17
> + with the expected ones in one specific platform (Mac)
"...just prints the..."
Sorry for duplicate comment. Can't edit comment on iphone
> Tools/ChangeLog:13
> +
-> Implemented by relying on....
More information about the webkit-reviews
mailing list