[webkit-reviews] review requested: [Bug 57846] ORWT shouldn't generate diff files for tests without expected files : [Attachment 88231] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 07:43:39 PDT 2011


Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 57846: ORWT shouldn't generate diff files for tests without expected files
https://bugs.webkit.org/show_bug.cgi?id=57846

Attachment 88231: proposed fix
https://bugs.webkit.org/attachment.cgi?id=88231&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
With this modification won't break the original goal of
http://trac.webkit.org/changeset/46607 , links to the new 
test results will work, but we shouldn't generate useless 
zero bytes sized expected.txt and a diff and pretty diff file.


More information about the webkit-reviews mailing list