[webkit-reviews] review requested: [Bug 57847] Crash logs not generated in 64-bit Windows 7 : [Attachment 88229] Proposed patch

[bugzilla-daemon at webkit.org]

Pere Martir <pere.martir4 at gmail.com> has asked	for review:
Bug 57847: Crash logs not generated in 64-bit Windows 7
https://bugs.webkit.org/show_bug.cgi?id=57847

Attachment 88229: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=88229&action=review

------- Additional Comments from Pere Martir <pere.martir4 at gmail.com>
run-webkit-tests doesn't find the correct location of ntsd.exe (NT Symbolic
Debugger) in 64-bit Windows.

To generate the crash logs, "Debugging Tools for Windows 32-bit Version" must
be installed as indicated in
http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs

Debugging Tools now comes with Windows SDK and the default installation
directory (not likely configurable) in 64-bit Windows is:

  C:\Program Files\Debugging Tools for Windows (x64)

Tools/Scripts/old-run-webkit-tests instead looks for:

  C:\Program Files (x86)/Debugging Tools for Windows (x86)

Note that "the 64-bit versions of Debugging Tools for Windows allow you to
debug both 32-bit and 64-bit user-mode applications running on 64-bit
processors."  64-bit version of Debugging Tools is also the one installed by
Windows SDK.

I've modified old-run-webkit-tests and successfully generated the crash logs.