[webkit-reviews] review denied: [Bug 57530] [Qt] GraphicsContext3D internal buffers are not freed : [Attachment 87685] fix

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jarkko Sakkinen
<jarkko.j.sakkinen at gmail.com>'s request for review:
Bug 57530: [Qt] GraphicsContext3D internal buffers are not freed
https://bugs.webkit.org/show_bug.cgi?id=57530

Attachment 87685: fix
https://bugs.webkit.org/attachment.cgi?id=87685&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87685&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:597
> +	   void* addr =
m_glWidget->context()->getProcAddress(QString::fromAscii(nameWithExt.utf8().dat
a()));

QString::fromAscii() is almost never valid inside a library. It does not
actually convert from Ascii, but from the default codec, which can be set to
anything by the user code.
You should use QString::fromLatin1() or QLatin1String() or in thisn case:
QString::fromUtf8().