[webkit-reviews] review denied: [Bug 57052] Infinite layout loop with two images sharing the same SVG image source : [Attachment 88110] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 05:52:34 PDT 2011

Nikolas Zimmermann <zimmermann at kde.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 57052: Infinite layout loop with two images sharing the same SVG image

Attachment 88110: Patch

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88110&action=review

Darin is right, this is not a good approach, can you investigate on how to
actually fix it? Maybe Simon can help.
I'm unfamiliar with the SVGImage code.

> LayoutTests/svg/css/up-arrow.svg:2
> +<!-- Generator: Adobe Illustrator 14.0.0, SVG Export Plug-In . SVG Version:
6.00 Build 43363)  -->

Please remove this line.

> LayoutTests/svg/css/up-arrow.svg:3
> +<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"

You can also omit this line.

> LayoutTests/svg/css/up-arrow.svg:4
> +<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" viewBox="10 10 30

id, xmns:xlink, x, y are not needed please remove.

> LayoutTests/svg/css/up-arrow.svg:5
> +<g>

This <g> is superfluous, you can remove it.

More information about the webkit-reviews mailing list