[webkit-reviews] review denied: [Bug 57796] [Qt] [WK2] Allow WK2 ENABLE_NETSCAPE_PLUGIN_API=0 to work in non-X11 unix environments : [Attachment 88152] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Keith Kyzivat
<keith.kyzivat at nokia.com>'s request for review:
Bug 57796: [Qt] [WK2] Allow WK2 ENABLE_NETSCAPE_PLUGIN_API=0 to work in non-X11
unix environments
https://bugs.webkit.org/show_bug.cgi?id=57796

Attachment 88152: Patch
https://bugs.webkit.org/attachment.cgi?id=88152&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88152&action=review

Why the guard #elif (PLATFORM(QT) || (PLATFORM(GTK))) && (OS(UNIX) &&
!OS(MAC_OS_X)) is not enough for your issue?
Your fix looks weird to me, the plugin architecture seems more general than
just NPAPI.

> Tools/Tools.pro:14
> +	  
exists($$PWD/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro):
SUBDIRS += DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro

Why do you change the indentation?