[webkit-reviews] review requested: [Bug 57826] [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT : [Attachment 88201] Patch proposal + Updated layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 04:35:42 PDT 2011


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 57826: [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
https://bugs.webkit.org/show_bug.cgi?id=57826

Attachment 88201: Patch proposal + Updated layout test
https://bugs.webkit.org/attachment.cgi?id=88201&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a simple patch (assuming 57463 fixed) + some changes in the
aria-tables.html layout test to allow unskipping it in GTK.

It might seem weird to have changed the html file to be able to unskip it, but
I think it was a good thing (providing semantics keep being the same) since
that way we don't need to have different HTML file for each platform, just
different expected files with the different strings got in the output for the
role names. See more fine-grained detail in the ChangeLog entry.

Last, I'd like to have unskipped as well the other two tests, but it seems that
would need some more changes somewhere else, so I'm not doing it right now.


More information about the webkit-reviews mailing list