[webkit-reviews] review requested: [Bug 57463] [GTK] ARIA tables not exposing cells as HTML tables do : [Attachment 88199] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 57463: [GTK] ARIA tables not exposing cells as HTML tables do
https://bugs.webkit.org/show_bug.cgi?id=57463

Attachment 88199: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=88199&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Back on business... I think this one is the good one, for a variety of reasons:


  * It doesn't assume that GTK ignores accessibility for table rows (which is
something happening right now, but could/should change in the future). Instead,
it adds extra code for the GTK platform so it works as expected _in case_ it's
ignoring accessibility for rows. This means that if in the future we decide not
to ignore rows anymore, current code in AccessibilityGrid and
AccessibilityGridCell should still work fine.

  * It works fine for different test cases I tried, inspired both in the
aria-tables-hierarchy.html and aria-tables.html test cases.

  * I checked with Accerciser and there's currently no difference, from AT's
point of view, between HTML and ARIA tables (which is what this bug is about).

  * It should keep the same behavior than before for other platforms (I
carefully checked this by visually inspecting the diff).

Of course, no sw/patch is free of bugs, but I think this patch is worth
considering for review anyway... :)