[webkit-reviews] review granted: [Bug 57760] Factoring the creation of 'FunctionOnly' callbacks in V8 : [Attachment 88086] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 5 02:57:52 PDT 2011
Steve Block <steveblock at google.com> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 57760: Factoring the creation of 'FunctionOnly' callbacks in V8
https://bugs.webkit.org/show_bug.cgi?id=57760
Attachment 88086: Patch
https://bugs.webkit.org/attachment.cgi?id=88086&action=review
------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88086&action=review
> Source/WebCore/bindings/v8/V8Utilities.h:61
> + CallbackRequireFunction = 1,
Would 'CallbackAllowFunction' be a better name, to keep all three consistent,
and to make clear what 'CallbackRequireFunction | CallbackAllowUndefined'
means?
> Source/WebCore/bindings/v8/V8Utilities.h:77
> + // 'FunctionOnly' is assumed for the created callback.
This comment seems a little odd. Maybe move it to above the method - 'Creates a
callback of the templated type from a V8 Value which represents a function
object. Values of null and undefined may be allowed, in which case the method
succeeds but the callback is null.'
More information about the webkit-reviews
mailing list