[webkit-reviews] review requested: [Bug 50952] Inputs of type "text" and "search" should support interoperable "set direction" functionality : [Attachment 88186] A quick fix v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 23:33:10 PDT 2011


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 50952: Inputs of type "text" and "search" should support interoperable "set
direction" functionality
https://bugs.webkit.org/show_bug.cgi?id=50952

Attachment 88186: A quick fix v5
https://bugs.webkit.org/attachment.cgi?id=88186&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Alexey and Eric,

Thank you for your reviews and sorry for my slow response. I have updated my
layout test to apply the comment from Alexey. It would be definitely helpful to
give me your feedback.

(In reply to comment #24)
> There is no need to force gc with your own code - js-test-pre.js provides a
nice gc() function.

Thank you for noticing it. It is really nice and I would love to use this
function.

(In reply to comment #25)
> Still LGTM.

Thank you again for your positive review. Even though the updated one is almost
as same as the previous one, would it be possible to review the updated one?

Regards,

Hironori Bono


More information about the webkit-reviews mailing list