[webkit-reviews] review granted: [Bug 57800] [Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification. : [Attachment 88167] Patch (v1)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jia Pu <jpu at apple.com>'s request for
review:
Bug 57800: [Mac] When autocorrection occurs without showing correction panel,
WebCore need to post accessibility notification.
https://bugs.webkit.org/show_bug.cgi?id=57800

Attachment 88167: Patch (v1)
https://bugs.webkit.org/attachment.cgi?id=88167&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88167&action=review

> Source/WebCore/editing/Editor.cpp:2417
> +			   Element* rootEditable =
m_frame->selection()->selection().rootEditableElement();
> +			   if (rootEditable)
> +			      
m_frame->document()->axObjectCache()->postNotification(rootEditable->renderer()
, AXObjectCache::AXAutocorrectionOccured, true);

It’s often better style to write it like this:

    if (Element* root =
m_frame->selection()->selection().rootEditableElement())
       
m_frame->document()->axObjectCache()->postNotification(root->renderer(),
AXObjectCache::AXAutocorrectionOccured, true);