[webkit-reviews] review granted: [Bug 57639] Move MouseEvent-dispatching logic into MouseEventDispatchMediator. : [Attachment 88158] Rebased to ToT.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 16:55:41 PDT 2011


Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 57639: Move MouseEvent-dispatching logic into MouseEventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=57639

Attachment 88158: Rebased to ToT.
https://bugs.webkit.org/attachment.cgi?id=88158&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88158&action=review

> Source/WebCore/dom/Event.h:207
> +    EventDispatchMediator();
> +
> +    void setEvent(PassRefPtr<Event>);
>      Event* event() const;

I’m surprised none of these are inlined in the header

> Source/WebCore/dom/EventDispatcher.cpp:67
> +Node* EventDispatcher::node() const
> +{
> +    return m_node.get();
> +}

Seems like an inlining candidate.


More information about the webkit-reviews mailing list