[webkit-reviews] review granted: [Bug 57665] [Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text. : [Attachment 88129] Patch (v3)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 4 16:44:16 PDT 2011
Darin Adler <darin at apple.com> has granted Jia Pu <jpu at apple.com>'s request for
review:
Bug 57665: [Mac] WebCore need to notify AppKit spell checker after user has
modified autocorrected text.
https://bugs.webkit.org/show_bug.cgi?id=57665
Attachment 88129: Patch (v3)
https://bugs.webkit.org/attachment.cgi?id=88129&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88129&action=review
> Source/WebCore/dom/DocumentMarker.h:40
> + // Text has been modified by spell correction, reversion of spell
correction or other types of substitution.
This would be better worded as "or other type" rather than "or other types".
> Source/WebCore/dom/DocumentMarker.h:41
> + // On some platforms, this prevents the text to be autocorrected
again. On post Snow Leopard Mac OS X,
Correct grammar would be "prevents the text from being autocorrected".
> Source/WebCore/dom/DocumentMarker.h:54
> // On some platforms, this prevents the text to be spellchecked
again.
Grammar: should be "from being spellchecked" rather than "to be spellchecked".
More information about the webkit-reviews
mailing list