[webkit-reviews] review granted: [Bug 57400] Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING) : [Attachment 87432] Check isComposited() before using the backing and remove the asserts.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted David Dorwin
<ddorwin at chromium.org>'s request for review:
Bug 57400: Fullscreen code assumes all layers use GPU compositing when
USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=57400

Attachment 87432: Check isComposited() before using the backing and remove the
asserts.
https://bugs.webkit.org/attachment.cgi?id=87432&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87432&action=review

> Source/WebCore/ChangeLog:9
> +	   Accelerated compositing may be compiled in but disabled at runtime
or for so

This sentence looks incomplete.

> Source/WebCore/dom/Document.cpp:4924
> +	    
page()->chrome()->client()->setRootFullScreenLayer(m_fullScreenRenderer->layer(
)->backing()->graphicsLayer());

Your indent is incorrect. (4 space indent in WK unlike chromium with a 2 space
indent).

> Source/WebCore/dom/Document.cpp:4949
> +	    
page()->chrome()->client()->setRootFullScreenLayer(m_fullScreenRenderer->layer(
)->backing()->graphicsLayer());

Ditto.