[webkit-reviews] review granted: [Bug 51230] Caps-Lock indicator never appears in WebKit2 : [Attachment 88113] proposed fix

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 51230: Caps-Lock indicator never appears in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51230

Attachment 88113: proposed fix
https://bugs.webkit.org/attachment.cgi?id=88113&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=88113&action=review

> Source/WebCore/ChangeLog:441
> -	   DumpRenderTreeÕs delegate to be dispatched. The delegate doesnÕt
expect to be called between
> +	   DumpRenderTree's delegate to be dispatched. The delegate doesn't
expect to be called between
>	   tests, and it references the layout test controller, which is null.
>  
>	   * page/Frame.cpp:
> -	   (WebCore::Frame::scalePage): Avoid an unnecessary layout if the page
scale isnÕt changing. This
> +	   (WebCore::Frame::scalePage): Avoid an unnecessary layout if the page
scale isn't changing. This

These characters should be re-encoded as UTF-8 rather than changed.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1173
> +    [[theEvent retain] autorelease];

A more modern pattern is to use a mysteriously-named RetainPtr for this. Or is
it not enough to retain the event for the scope of this function?